• src/sbbs3/services.c

    From Rob Swindell@1:103/705 to Git commit to sbbs/master on Sat Sep 26 18:24:35 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/2ec90d7a5e2b30b7f2fcd471
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Place socket error description at the end of the logged messages.Socket error descriptions on Windows can be quite long (e.g. > 128 chars) andinclude punctuation, so include at the end of logged socket error messages.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sat Feb 20 17:31:34 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/9af56407b142a029bea9ec5c
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Track client counter per service againAdd the "two or three lines" that Deuce said were needed to restore this functionality.Also got rid of some now unnecessary (void) protected_*int* return value ignoring warning-suppressors.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Feb 28 13:22:48 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/452e65d884ccae63634d0cad
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Fix "clients remain" log line issue introduced in 9af56407The service clients count is now a protected int, so deal. On Windows, this was resulting in the "total" and "served" values logged as 4294967295.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Feb 28 14:33:05 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/82b99558796630a824a2427e
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Merge branch 'master' of gitlab.synchro.net:main/sbbs
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Apr 4 13:38:22 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/3c911b9105131c6d84f21ce0
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Fix UDP buffer memory leak when max clients reachedCaught by Coverity-scan CID 330055
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Mon Apr 5 12:03:56 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/a1f9abb72c2b6e2fb129fedd
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Set fds to NULL before recycle.Likely the cause of the crash that killed cvs.synchro.net last night
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Tue Apr 6 18:37:13 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/112526fe8dc12c84243955c2
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Include user alias in logged JS error/warning messages
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Tue Mar 1 22:43:08 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/7117b4d8a85474975ea81c78
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Probably doesn't resolve the Coverity issueBut good practice anyway
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Wed May 11 00:37:31 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/b293b6e53e751fff783f90c2
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Allow a per-service "LowestLogLevel" settingHave a service (e.g. imapservice.js) that logs errors that you'd rather not fill your error.log file with? Set that service's "LowestLogLevel" to "Warning" in your services.ini file ("lower" means "more severe" when it comes to log levels, so this would set the maximum severity to Warning).
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Aug 21 18:35:34 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/9bd552ed13142092f54e2b2b
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Improve JavaScript-related error messages and fix potential JS runtime leakIf a new JS context could not be created for any reason, a JS runtime wouldstill be allocated (and leaked), potentially leading to out of memorysituations which had been seen (before this change) on vert.synchro.net.
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on ChromeOS)@1:103/705 to Git commit to main/sbbs/master on Thu Jan 26 23:45:00 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/4d8bb33e8ffd2e37e5e7b4ba
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Use XSAFECOPY in place of SAFECOPY to avoid NULL pointer checks
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (in GitKraken)@1:103/705 to Git commit to main/sbbs/master on Sun Mar 12 00:00:02 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/f40e7fbd4471344721a998e9
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Fix a couple of potential NULL-pointer deferences in js_initcx() failure casesservice_client->client is NULL in these failure/error cases, so get theprotocol string from the service_client->service (which is not NULL) instead.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Mon May 1 12:00:24 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d057ff6d2d14f5be4e219833
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Fix valgrind-reported memleak (on recycle), not freeing interfaces string list(seeing a pattern here) :-)
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Fri Oct 20 20:19:52 2023
    src/sbbs3 services.c 1.330 1.331
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv16636

    Modified Files:
    services.c
    Log Message:
    Fix long standing bug with the global JS function login():
    A few *service.js scripts call this function without a password argument
    (the second argument), e.g. login("guest");
    If there was no guest account (or the guest account had a password assigned), this would result in a failed login attempt as "guest" along with a garbage password (e.g. a floating point number, like 3.7042561) and since it would
    be a unique garbage password for each login() call without an actual password specified, these login() calls would be counted as unique failed login attempts and potentially cause the client's IP address to be added to the hack.log
    and even ip.can (IP address filter).

    As seen on Mortifis' system where VERT was filtereed due to
    "SUSPECTED NNTP LOGIN HACK ATTEMPT", likely due to the daily sbbslist verifications when just perform a TCP connection and no actual login attempt, but nntpservice.js would still call login("guest") before the client (vert) would be disconnected.


    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sun Dec 17 01:14:27 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/41b6e894c55e20e20a4aae64
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Log client IP address in "Logging in" log message
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sun Dec 17 01:37:48 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/76706b71762af88781ab5922
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Fix bug in previous commit: wrong client->addr
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Mon Jan 29 11:42:45 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/5634092ad3f89d6e63fd52d9
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Fix apparent session leak in services.

    It appears that after successful completion of a JS service, the
    TLS session is never destroyed.

    If this fix isn't valid for #707, we should see a bunch of
    "Destroying a session (...) that's not in sess_list" log messages

    Thanks Keyop!
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Wed Feb 7 14:47:35 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9c9d6a151e2f7fa2e19305e9
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Another time_t printf
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Thu Jul 11 18:32:37 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/8dfbba2f749476ede8d78dc2
    Modified Files:
    src/sbbs3/services.c
    Log Message:
    Track/log/publish-to-MQTT services server (total) client highwater mark

    Like the other servers.

    A sysop likely would want to know which services/protocols had what
    utilization (as a portion of the total highwater mark), so that'll have to
    be added later.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)