• src/sbbs3/js_uifc.c

    From Rob Swindell@1:103/705 to Git commit to sbbs/master on Sun Sep 13 12:37:14 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/fdf57f2a14f6173f86d1ed94
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Fix error return value of list methodbool (JSVAL_FALSE), not number (JS_FALSE). --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Michael Long@1:103/705 to Git commit to main/sbbs/master on Sat Nov 28 13:09:03 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/4f9c26f6236a03e1ce8a9433
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    misspellings in jsdocs
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sat Nov 28 13:09:03 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/b6a2b71067c53da9c46c2e6e
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Merge branch 'patch-1' into 'master'misspellings in jsdocsSee merge request main/sbbs!40
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deuce@1:103/705 to Git commit to main/sbbs/master on Fri Jan 29 00:02:18 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/4f087081761db61dc49813d4
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Add some more uifc functions to the uifc object.scrn, showbuf, timedisplay, bottomline, getstrxy
    --- SBBSecho 3.12-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Fri Jan 29 00:07:13 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/8482a03bc495d124bbf4d933
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Remove training whitespaces.
    --- SBBSecho 3.12-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Fri Jan 29 00:22:33 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/e79fd123610d02572b2f7bc3
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Showbuf context has more now!
    --- SBBSecho 3.12-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Fri Jan 29 21:56:03 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/8404da742cd011e181660b85
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    uifc.list() returns a number, not a stringStop lying. Programming is hard enough already.
    --- SBBSecho 3.12-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Wed Mar 31 13:50:08 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/84111584a0086e0e1317d1a0
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Fix showbuf context issues.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Wed Mar 31 14:01:52 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/f203d5dfc860109a43ade151
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Set a better default window for uifc.showbuf()Rather than defaulting to zero lines high and the width of the title,default to the entire screen area.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Wed Mar 31 21:19:49 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/205b3571d01e520112f32ae6
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Make context defaults for with and height same as no-context ones.ARE YOU HAPPY NOW CYAN?!?!
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Apr 4 15:13:57 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/a03d1d3786da4f42444c635a
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Remove logically dead codePROP_CHANGES already handled in if() conditionCID 33176
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Mon Feb 20 14:16:00 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/2a2c6ed4ffdb1d31c5fbd8a2
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Fix insufficient 'mode' string length in init() methodLimited to 6 chars, yet some values are as long as 12 chars.Also, eliminates this warning from RELEASE builds (only) using gcc version12.2.0 (Debian 12.2.0-14):js_uifc.c: In function ‘js_uifc_init’:sbbs.h:230:56: warning: writing 8 bytes into a region of size 7 [-Wstringop-overflow=] 230 | (ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’ 242 | JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \ | ^~~~~~~~~~~~~~~~~~~js_uifc.c:609:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’ 609 | JSVALUE_TO_ASTRING(cx, argv[1], mode, 7, NULL); | ^~~~~~~~~~~~~~~~~~In file included from sbbs.h:255:/home/rswindell/sbbs/src/sbbs3/../xpdev/genwrap.h:77:20: note: destination object of size 7 allocated by ‘__builtin_alloca’ 77 | #define alloca(sz) __builtin_alloca(sz) | ^~~~~~~~~~~~~~~~~~~~sbbs.h:228:43: note: in expansion of macro ‘alloca’ 228 | if(((ret)=(char *)alloca((*JSSTSlenptr)+1))) { \ | ^~~~~~sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’ 242 | JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize), (lenptr)); \ | ^~~~~~~~~~~~~~~~~~~js_uifc.c:609:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’ 609 | JSVALUE_TO_ASTRING(cx, argv[1], mode, 7, NULL); | ^~~~~~~~~~~~~~~~~~
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on ChromeOS)@1:103/705 to Git commit to main/sbbs/master on Sat Oct 28 18:39:39 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/13b61182ea5e0084fab1acc2
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    'prompt' argument missing from uifc.input() JSDOC

    Also clarify (or try to clarify) that the maxlen argument is required if you want to specify any kmode flags.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on ChromeOS)@1:103/705 to Git commit to main/sbbs/master on Sat Oct 28 18:51:55 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b4c97d4673102605ccccda92
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Document all the parameters to and return value of uifc.input()
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on ChromeOS)@1:103/705 to Git commit to main/sbbs/master on Sun Oct 29 17:47:10 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/a3f62409cf84c5d5946e122c
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Update JS docs for uifc methods

    The CTX constructor arguments weren't documented

    Some blind beautification via HTML tags
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Tue Mar 5 15:37:58 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/0121fc5ff50c2e53e35a46e0
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Make uifc.input.CTX and uifc.showbuf.CTX constructors match assumptions/docs

    This one has caught me up before, for the CTX constructors didn't actually accept any initial property values (as arguments).

    mlong even documented it this way at https://wiki.synchro.net/ref:uifc#javascript_interface

    And construted his input.CTXs this way (using all 0 values, which were
    ignored) in his xtrnmenucfg.js
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Tue Jun 18 22:40:02 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/91059084757d5c218e7b4b56
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Use new uifc.list mode flag WIN_BLANKOPTS

    uifc option lists are always NULL-terminated string lists (not static
    arrays of char arrays, as is often used in other UIFC utils), so grow
    the ability to have blank options (list items).

    This was needed for fileman.js to accurately edit extended file
    descriptions that contain blank lines.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Fri Jun 21 00:26:42 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/16525f870b76c17a25ef3fa1
    Modified Files:
    src/sbbs3/js_uifc.c
    Log Message:
    Use the new uifc_t.restore() method when decrementing the save_num

    This is the proper way to manually-restore the most recently saved
    window (via the WIN_SAV mode flag to the list() method).

    I wanted something that was backward comaptible with earlier builds
    of SBBS, so just doing a magic thing when decrementing the save_num
    rather than adding a new method seemed the seamless way to do it.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)