• src/sbbs3/logon.cpp

    From Rob Swindell@1:103/705 to Git commit to sbbs/master on Sat Sep 12 23:56:05 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/67edda7341b4d9a6a978eb69
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Automatically switch back from PETSCII to ANSI modeIf the user's terminal was auto-detected as being ANSI, yet they had theiraccount settings manually-overridden to use PETSCII, automatically switchback to auto-terminal mode (e.g. with ANSI).
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Thu Sep 24 22:08:32 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/34d46c3ef247966350809b53
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't force password-changes for users with blank passwords (e.g. Guest)Wow. This is another one of those "forever bugs".
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From MRO@1:103/705 to Rob Swindell on Sat Sep 26 16:27:00 2020
    Re: src/sbbs3/logon.cpp
    By: Rob Swindell to Git commit to sbbs/master on Thu Sep 24 2020 10:08 pm

    https://gitlab.synchro.net/sbbs/sbbs/-/commit/34d46c3ef247966350809b53 Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't force password-changes for users with blank passwords (e.g. Guest)

    Wow. This is another one of those "forever bugs".

    aw man, i liked that one
    ---
    Synchronet ::: BBSES.info - free BBS services :::
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Mon Oct 12 08:50:48 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/0a785fa5677d43760fbbad7a
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Fix birth month check during logon.New bug, reported by Melkor (STARFRON).
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Tue Nov 17 19:53:01 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/733ddc699d4b6c1a1ead869b
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    If all waiting-mail has been read, don't default to "Yes" read mailCount the read mail-waiting and compare to the total mail-waiting and if they're the same, then default to "No" for the "Read Your Mail Now" prompt during logon.Also, pass the difference (the unread mail) to the LiMailWaiting logon-info line.As requested by altere via I.R.C.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Tue Nov 17 20:59:39 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/721b6a54ebb9f0bf357b67dc
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Fix inverted logic of noyes() prompt in previous commit.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Tue Jan 25 19:17:32 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/3f17c245f7a2e514826e9a26
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't modify useron.misc during logon, even for AUTOTERMWe shouldn't need to set any of the autoterm flags in useron.misc these days (term_supports() checks autoterm when appropriate).Try this Nelgin.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Tue Jan 25 22:18:33 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/88cef39afc51baf131c5a41f
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Beautification of the previous commitAnd don't store the autoterm flags in useron.misc even when correcting a manual-PETSCII configuration.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Feb 6 02:13:58 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/f5fed0b229e70b79a5ebb330
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Fix access-control by terminal cap issue introduced a week agoIn commit 3f17c245, I was addressing the issue reported by Nelgin via IRC:<nelgin> If you login using a term that doesn't support ansi, it changes your settings - can you set 'em back when done?<DigitalMan> if you have auto-term enabled, it doesn't actually change your settings, just what's in use during that session<nelgin> I logged in using my BBC emulator which doesn't do ansi, then when I logged in through syncterm, I got the display like it was on the BBC. All my characters replaced with #'s and stuff.<nelgin> I had to go back into the user menu to fix it. That is going to confuse users.However, the chk_ar() function in userdat.c which is used to populate JS objects (e.g. xtrn_area.sec_list[].prog_list[]) uses the user.misc value (cannot call term_supports()), so the current user terminal flags need to be reflected in user.misc always. So the real fix for the originally reported problem is to clear the charset-related terminal settings when logging in with auto-terminal settings enabled (and before the auto-detected charset flags are OR'd in).I toyed with the idea of storing a copy of the term_supports() result in client_t, which is passed to chk_ar() when appropriate, but decided that was a bit overkill and there were issues with servers that don't have term_supports (e.g. the web server) and properly populating access-controlled areas in the JS object model (e.g. door games that require ANSI). Better to use the last-auto-detected terminal caps than assuming "no" terminal capabilities in that scenario.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (in GitKraken)@1:103/705 to Git commit to main/sbbs/master on Thu Mar 2 18:56:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/c0ef762adf57ff91307c3015
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Remove defunct files from batch download queue during logonIf a user doesn't have access to download a file that's in their batch queue, remove it without saying anything to the user (but log a notice-level message about it) during logon. Files that no longer exist in the filebase are treated the same way.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Mon Jul 24 17:21:26 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/8266da9c329d2ba49ff2001c
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Log an error if getstats() returns a failureI saw my logon.jsonl file getting cycled multiple times a day recently on Vertand suspect this function call may have been failing.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Mon Jul 24 18:25:35 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/e12c35049251dc97e8eafd7c
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Revert "Log an error if getstats() returns a failure"This reverts commit 8266da9c329d2ba49ff2001cf542a0d05dc9987e.We're already passing a sock_init callback (ls_cb) which is supposed to setthe socket options (call set_socket_options), so this change shouldn't benecessary and reportedly caused more issues binding ircd sockets when runningircd.js via jsexec (though I didn't see this myself).
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Mon Jul 24 18:27:43 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/46f1f80e75b30d477cdb419c
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Revert "Revert "Log an error if getstats() returns a failure""This reverts commit e12c35049251dc97e8eafd7c7fc12dfd9ba13ad9.Wrong commit reverted. Oops.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Wed Sep 13 16:27:23 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/65f1df280bc72439e80b8a9f
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    A todo comment
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Fri Oct 20 20:19:52 2023
    src/sbbs3 logon.cpp 1.71 1.72
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv11700

    Modified Files:
    logon.cpp
    Log Message:
    Log "Fast-Logon" (when user is using fast logon), rather than just "Logon".


    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sun Feb 4 18:45:55 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/cbf6a8b24c615e753801dbd2
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    I'm not sure what "node message indices" (data/msgs/*.ixb files) are/were

    I don't recall this actually being a thing, ever, so certainly no reason to
    be cleaning these files up during logon. <shrug>
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Mon Feb 26 23:07:48 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/f315f34ce2c8b91e656fc5a4
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Change "On two nodes" to "On more than one node", since it's possible it's > 2 --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Mon Feb 26 23:22:29 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9544a3c6bf36555a2babc6bb
    Modified Files:
    src/sbbs3/logon.cpp
    Log Message:
    Don't send NodeLoggedOn message to any nodes if user isn't being logged-on

    If user is being kicked off for being on "More than one node at a time", then don't send a message to other any other nodes that the user logged-on successfully (they haven't). Previosuly, it'd send messages to all the lower-numbered nodes that were in-use (but not by the same user).

    Reported by Nelgin.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)