• src/sbbs3/sbbsecho.c

    From rswindell@1:103/705 to CVS commit on Wed Apr 29 21:47:15 2020
    src/sbbs3 sbbsecho.c 3.169 3.170
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv20270

    Modified Files:
    sbbsecho.c
    Log Message:
    Remove unnecessary typecasts.

    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rampage@1:103/705 to digital man on Thu Apr 30 07:56:04 2020
    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Wed Apr 29 2020 21:34:37


    Modified Files:
    sbbsecho.c
    Log Message:
    When importing messages into a local msgbase that contained an origin
    line but no tear line, I noticed that the initial space before
    "* Origin" was absent from the tail. It turns out the missing space character was being appended to the end of the body text. While investigating why that was, I was dismayed at the cruftiness of code
    but totally suprised that there was 80-column word-wrap logic in here
    (!). Removed that word-wrap logic <blush> and fixed the origin thing.
    More clean-up coming up next.

    i'm glad you found this! i had thought to go rummaging through the code looking to see if there was such in place but the TODO list is quite long... i've been noticing a difference in the formatting of posts when compared to how they arrive via QWK and when they're gated to FTN... i'm curious to see if they're now more similar or exact to the QWK arrivals when seen on the FTN side... they should be, now, with this forced 80 column formatting removed :)


    )\/(ark

    ---
    Synchronet The SouthEast Star Mail HUB - SESTAR
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Digital Man@1:103/705 to Rampage on Thu Apr 30 12:06:56 2020
    Re: src/sbbs3/sbbsecho.c
    By: Rampage to digital man on Thu Apr 30 2020 07:56 am

    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Wed Apr 29 2020 21:34:37


    Modified Files:
    sbbsecho.c
    Log Message:
    When importing messages into a local msgbase that contained an origin line but no tear line, I noticed that the initial space before
    "* Origin" was absent from the tail. It turns out the missing space character was being appended to the end of the body text. While investigating why that was, I was dismayed at the cruftiness of code
    but totally suprised that there was 80-column word-wrap logic in here (!). Removed that word-wrap logic <blush> and fixed the origin thing. More clean-up coming up next.

    i'm glad you found this!

    If someone had asked, I would have said that SBBSecho did not do that.

    i had thought to go rummaging through the code
    looking to see if there was such in place but the TODO list is quite long... i've been noticing a difference in the formatting of posts when compared to how they arrive via QWK and when they're gated to FTN... i'm curious to see if they're now more similar or exact to the QWK arrivals when seen on the FTN side... they should be, now, with this forced 80 column formatting removed :)

    Cool, let me know what you find.

    digital man

    Synchronet "Real Fact" #45:
    Synchronet External "Plain Old Telephone System" support was introduced in 2007.
    Norco, CA WX: 73.9F, 69.0% humidity, 0 mph SSE wind, 0.00 inches rain/24hrs --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Thu Apr 30 17:08:23 2020
    src/sbbs3 sbbsecho.c 3.170 3.171
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14414

    Modified Files:
    sbbsecho.c
    Log Message:
    Always delete exported netmail if there's no SENDEREXT (from_ext) as this could result in orphaned sent-mail otherwise.

    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Tue Apr 21 20:25:34 2020
    src/sbbs3 sbbsecho.c 3.159 3.160
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6003

    Modified Files:
    sbbsecho.c
    Log Message:
    Remove attributes CRASH, HOLD, and LOCAL from the headers of netmail messages be unpacked into stored messages (.msg). Debug-level log message indicating that one or more attributes were removed (and which ones, in hex).
    This set of stripped attribute flags could easily be configurable, if that turns out to be desirable.

    --- SBBSecho 3.10-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Wed Jul 15 21:11:55 2020
    src/sbbs3 sbbsecho.c 3.173 3.174
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22900

    Modified Files:
    sbbsecho.c
    Log Message:
    If an export netmail message has MSGID/REPLY header fields, add those as kludges (needed for including message-IDs in exported netmail).

    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Sat Jul 18 20:42:28 2020
    src/sbbs3 sbbsecho.c 3.174 3.175
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1776

    Modified Files:
    sbbsecho.c
    Log Message:
    Extra log level message (INFO, WARNING, and DEBUG) when moving netamil file attachments (attached files) - for debugging the issue reported by
    alterego (ALTERANT)

    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Sun Jul 19 11:50:39 2020
    src/sbbs3 sbbsecho.c 3.175 3.176
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv10832

    Modified Files:
    sbbsecho.c
    Log Message:
    import_netmail(): Safer string handline and a bit more/consistent log output around attached file handling (especially if mv() fails).

    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Thu Sep 24 20:20:57 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/57afc83c4a58a1a7f6af05ee
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Signal the sub-board's configured semaphore file when importing echomailAt the request of alterego (ALTERANT), if a sub-board has a "post semaphore"configured, signal (touch) it whenever a message is imported via SBBSecho intothat sub-board.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Thu Sep 24 20:34:10 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/ddba8d7cec9cd0367d7e0480
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix previous commit: we need to use mycmdstr(), not cmdstr().
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Fri Sep 25 17:57:04 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/da486a78c63293a86718c78d
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't attempt to parse origin addr from origin lines in NetMail msgsApparently, some versions or configurations of Mystic BBS will include anOrigin Line in FTN NetMail messages. That would've been okay for SBBSecho,except these origin lines do not contain an FTN address (in parenthesis).So, firstly: when importing NetMail messages (subnum=INVALID_SUB), don'tattempt to parse any Origin Lines. Secondly, fix up the Origin Line parsecode a bit better detect the case when no FTN address is actually present.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Fri Nov 20 21:38:16 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/6380257eb617c61048195583
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Support forwarding FTN netmail to user's forward-to netmail addressThere's no new opt-in option for this new feature - maybe there should be.For geneb.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Sat Nov 21 12:18:30 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/796c3db7d2e5fdb81b1c4dff
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    A better check of a user's netmail-forwarding address.is_supported_netmail_addr() actually takes the system configuration and QWK routing table into account. No sense forwarding to a non-deliverable address.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Sat Nov 21 12:59:53 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/efbb1b5d5577a05515f1f6e5
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Revert "A better check of a user's netmail-forwarding address."This reverts commit 796c3db7d2e5fdb81b1c4dff884e15d66718063c.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Sun Nov 22 14:28:50 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/cbda86ec8738498c14ae87fb
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix netmail forwarding (new feature)The recipient net-addr/type was always being over-ridden a bit further down in the code. Don't do that.Also, log a message (sbbsecho.log) indicating that a message was forwarded ("Forwarding message ...").For geneb.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Wed Dec 9 22:29:28 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/a1e127841841087fb51e1c32
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't repeate mail "comment" headers in exported netmail msgssmb_getmsgtxt() returns any "comment" headers as part of the message body text, and has since 2003.When I added mail->netmail (stored message) export support to SBBSecho v3, I duplicated this logic, so comment headers were added *twice* to exported netmail messages. Oops. I didn't notice until today when playing with forwarding-to-netmail (FTN).Also noticed and fixed: any comment headers in posted messages (unlikely/uncommon) would not be exported to EchoMail messages. Use the correct smb_getmsgtxt() mode flags ("NO_TAILS" instead of "BODY_ONLY") - I know, not great names.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thu Dec 24 16:28:13 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/c590c437c7dee6de8531217b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Use QWKnet ID of originating system when imported via QWKnetUpdate to previous commit.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Feb 14 17:17:59 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/53d3103177986398c19564a3
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    When replying to PING netmails, use the destination addr as the origaddrAs tested and reported in FIDONEWS by Michiel van der Vlist, 2:280/5555, SBBSecho would use the "best match" FidoNet AKA for the originating address when replying to PING netmail messages and not necessarily the original destination address of the ping request. For systems that have multiple addresses (AKAs) that could be considered appropriate originating addresses for the requesting node address (e.g. multiple addresses in the same zone or zone/net), this could cause a confusion for the PING requester.The create_netmail() function now accepts an optional source (orig) address parameter and the PING response logic passes the netmail's destination address for the reply message's originating (source) address.I noticed that AreaMgr responses also follow the same logic as PING responses (just use the best-fit AKA, not necessarily the same address as the original request's destination address) - but I did not choose to address that "issue" at this time.
    --- SBBSecho 3.12-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Feb 21 19:25:49 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/a9967b46fc2be2e0d08efb49
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix memcmp() usage problem introduced in previous commitCaught by GCC.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Mon Feb 22 00:27:34 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/a1bead7cc4e295514a5c1b18
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Eliminate a large pass-struct-by-valueCaught by Coverity.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Mon Feb 22 14:44:06 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/160606e4ce35305a55819266
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Print error and return NULL from getfmsg() upon ftell errorCaught by Coverity - ftell[o] can return negative.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Apr 4 13:38:22 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/f3e4a6e498c8c206e087da88
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Use SAFECAT() instead of strcat() for more safety.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thu May 20 02:48:11 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/1031d0f6e01686c5a8dda583
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Replace tempnam() usage with the suggested mkstemp()Since we're cleaning up warnings... this will break the Windows build for now.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sat May 29 19:32:50 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/0f262d8ab2a6bd870adbb428
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't allow downlinks (AreaFix add) of our "Unknown echoes" sub-boardIt was recently pointed out to me that a downlink could link to the '*' echo via Area Manager (AreaFix) request. This was not intentional.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sat May 29 20:12:09 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/7f0390149d84d79a3b7bfb10
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Keep the same area file (areas.bbs) mode flags (permissions)When executing area manager requests that alter the area file, the temp areafile created (with mkstemp) had mode 0600 (owner read/write only). The sysopvery possibly had different permission flags they want to keep for their areafile, so copy the mode flags from the original area file to the temp/new areafile.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sat May 29 20:16:25 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/9a8c8e6d414c2bfe503aa841
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Microsoft doesn't have fchmod(), so use chmod() on the closed file
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Wed Oct 6 18:38:09 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/ccc0e4019838ce4021c16b0e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    When packing netmail (stored messages), don't discard non-zero zonesAs reported by Ragnarok (DOCKSUD) via DOVE-Net, when packing (packetizing) netmail messages, the source and destination zones from the netmail header were discarded (since they are defined as "optional" in FTS-1) and the zone values were replaced with the system's primary/default zone number. If the netmail message included an INTL kludge, the source and destination zone values would be parsed from that kludge line and this issue would not be noticed. So the fix is: Only if the netmail message header contains a source or destination zone number of 0, replace that zone with the system's primary/default zone number. As before, the INTL kludge zone information can override the header fields.Also, there's no reason to force the point numbers from the header to zero, since if they were not valid (e.g. "fill" in the original FTS-1 specification), they would be already zero. So use the source and destination point numbers, as is, from the netmail header too (with the FMPT and TOPT kludge override support left in-tact).
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thu Nov 11 18:43:46 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/5012efb1eb3d2d20289a01c1
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Log an error and exit immediately when a local linked-node is configuredWhen a linked-node (in echocfg->Linked Nodes) contains one of the local system's FTN addresses, display/log an error and exit immediately, e.g.:Configuration ERROR: Linked node #20 is your own address: 1:103/705I'd perform this check in EchoCfg, but:1. echocfg doesn't read the BBS's configuration files (where the local FTN addresses are configured), and2. some sysops just directly edit their sbbsecho.ini file
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Fri Nov 12 14:09:35 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/e10b39d1aee183a16a3d9458
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Generate a MSGID kludge for netmail messages created by SBBSechoThe "serialno" field is a bad/naive one (a time_t value), but this is really just an experiment for Ragnarok to see if this fixes issue #306 (with hotdoged receiving AreaFix responses/notices).
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thu Nov 18 17:38:10 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/27dfa4f6b9ebc59e1c4f097e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Resolve gcc warningwarning: format ‘%lx’ expects argument of type ‘long unsigned int’
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thu Jan 13 17:04:35 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/55962a410034e3633fe3ff09
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Disable libarchive support for creating/appending bundleslibarchive apparently cannot be used for in-place modification of (e.g. adding files to) existing archives, so if a bundle already exists, this code would over-write it with a new archive containing just the latest packet. Issue reported by acn (IMZADI) via DOVE-Net.I could and might create an update_archive() function which extracts and re-creates an archive with additional files, but since I don't have that yet, just disable this for now and always use an external archive utility to create or update bundles (so again, an "Archive" configuration is required in your sbbsecho.ini file, which you most likely already have).
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Tue Mar 1 22:43:08 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/4ec5647c783a5f5af9d68611
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Resolve some Coverity-discovered issueswith lseek() argument types, ftell() return type, etc.Likely none of these would be actual issues with files < 2GiB in size.
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Wed Mar 2 10:07:45 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/f9a681ac286284fe57f7f5c2
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix possible negative offset to fseeko()CID 350353
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Fri Mar 11 00:08:19 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/c4b6a79d6f3a6b217cb87a1b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Add subject.can (Subject filter file) supportFor Trikester (DOVEMOD/BSMNTQQ) --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Mar 13 00:38:44 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/e530a12cf6268ef9ab47f36c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix CID 174355: Big parameter passed by value
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Apr 3 16:51:09 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/726223ee8d8a7dde927fc833
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    For sub-boards configured to export "ASCII Only", convert UTF-8 correctlyThis converts the body text as well as the to, from, and subject headerfields (first to CP437, then to ASCII).This should address the issue raised in issue #386 with exporting UTF-8sequences to some message networks.
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Mon Apr 4 05:36:28 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/bf3da76e32fbc8cd7785fa1f
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Resolve GCC warningsFixes isue #388 - no change in behavior
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Tracker1@1:103/705 to Rob Swindell on Mon Apr 4 18:56:06 2022
    On 4/3/22 16:51, Rob Swindell wrote:
    https://gitlab.synchro.net/main/sbbs/-/commit/726223ee8d8a7dde927fc833 Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    For sub-boards configured to export "ASCII Only", convert UTF-8 correctly

    This converts the body text as well as the to, from, and subject header fields (first to CP437, then to ASCII).

    This should address the issue raised in issue #386 with exporting UTF-8 sequences to some message networks.

    Maybe adding a "CP437/DOS Only" option? Not sure what the underlying
    value is though.
    --
    Michael J. Ryan - tracker1@roughneckbbs.com
    ---
    ■ Synchronet ■ Roughneck BBS - roughneckbbs.com
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Wed Apr 13 18:35:02 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/414d34ec8bc2c13601ce476a
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix packet filename in "Gruned message" log entry on Win32e.g. "Grunged message (type 2) from 4:80/1 at offset 58 in packet: (null)"off_t is 64-bit, but long in 32-bit (on Win32), so needs a typecast here inlprintf() call (otherwise, the upper 4 bytes of the offset are interpretedas the string address for the corresponding '%s' argument, the filename).
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thu Apr 21 22:09:52 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/2962e4a5bf733e4b0c3869c4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix segfault when printing Bad-echo name after failing to load cfgThis is a weird one: sbbsecho ran right as I was saving msgs.cnf viaSCFG and it seems like it loaded 0-byte msgs.cnf into memory and thissegfault was a result of trying to print sub[INVALID_SUB]->code.The use of [f]nopen() with proper share perms should have prevented this(truncated msgs.cnf read) from happening, so there's something else afoot here.
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (in GitKraken)@1:103/705 to Git commit to main/sbbs/master on Thu Feb 16 00:01:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/6fb20b919003c805a40c207c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Resolve signed/unsigned compare warning with MSVC
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on ChromeOS)@1:103/705 to Git commit to main/sbbs/master on Sat Feb 18 12:59:30 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/ccfad124e104b09bf825392e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    More consistent 'exact' parameter values to findnodecfg() - e.g. false, not 0No functional change.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on ChromeOS)@1:103/705 to Git commit to main/sbbs/master on Sat Feb 18 12:59:30 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/15b230af547ff5932c6073e5
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Rework NetMail routing logic to handle point destinations betterWith this commmit, the logic is now:If the NetMail destination is a point and there's no linked-node for it and the boss node for this point is not one of our AKAs then route to the boss node (no linked-node match needed) if the boss node matches a linked-node with a route configuration then route to that configured route destination (2-levels of routing and thus 2 "Routing NetMail" msgs will be logged in this scenario)If the NetMail destination is a point and there is a linked-node for it then the netmail will not be routed unless that linked node has a route configurationNetMail destined for non-points are treated the same as before thiscommit.No change in the routing of echomail for points.I think this change fixes issue #520 which can be traced back to commit45ced2a3b for poindexter FORTRAN (REALITY), 2 years ago almost to theday, where that change added point->boss routing, but only if the bosshad a matching linked-node configuration (for both echomail andnetmail).This commit also re-thinks commit ffe69b43623d (for Alterego) whichwould not route a point netmail if any our local AKAs matched thedestination address, igorining the point value. I think what wasintended here (I coudln't locate the original enhancmenet request orissue), was to not route if a local AKA was the *boss* of the point.And with this commit, that's now how it now works.As before, "test results appreciated".
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From poindexter FORTRAN@1:103/705 to Rob Swindell (on ChromeOS) on Sat Feb 18 18:45:27 2023
    To: Rob Swindell (on ChromeOS)
    @MSGID: <63F18D47.12151.dove.sync_c@realitycheckbbs.org>
    @REPLY: <63F13C32.46548.syncprog@vert.synchro.net>
    @TZ: 41e0
    Re: src/sbbs3/sbbsecho.c
    By: Rob Swindell (on ChromeOS) to Git commit to main/sbbs/master on Sat Feb 18 2023 12:59 pm

    As before, "test results appreciated".

    Thanks for doing this. I'm relying on the nightlies, so I'll download them tomorrow and test.
    ---
    Synchronet .: realitycheckbbs.org :: scientia potentia est :.
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Sat Apr 15 19:45:46 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/227e2f4986eb0b04c05cc6ea
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Stop classifying msgs for unknown areas as security violationsWhen Secure EchoMail is enabled and a Bad Echo Area (*) is defined in thearea file (areas.bbs), but the packet source address is *not* listed as alink to the Bad Echo Area (tag: *) in areas.bbs, any messages for unknownareas in such a packet would cause the pkt to be considered a bad packetwith a security violation. Instead, the message should just be skipped.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Tue May 30 17:27:04 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b185201161cd35dea8273d84
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Strip the "in-transit" attribute flag from imported packed-messagesLog a warning message when either the "local" or "in-transit" flag has beenstripped from ("Sanitized") imported packed-messages.Keyop reported a chksmb warning on a FidoNet message that contained the'in-transit' attribute:<Keyop> Message flagged as 'In Transit' (?): 1<Keyop> fidonet_fidosoft Message Base has Errors!The message in question appears just to be a corrupted echomail msg comingfrom HPT:Sender '56:43 'To Tommi KoivulaSubject testX-FTN-AREA FIDOSOFT.HUSKYX-FTN-TID hpt/os2-wc 1.9.0-cur 2021-03-14SBBSecho didn't use to convert/import the "in-transit" flag on importednetmail or echomail messages, ... until commit 446ab0ef7e09e5c61cf, whichwas needed to support the TickFix robot. So now, let's just sanitize thepacked-message attributes a little sooner in the import process and log awarning when such sanitization has taken place.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Tue May 30 17:27:04 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d6eadf369e7ed75248b1819c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Truncate trailing whitespace from FidoNet message header fieldsIt's unclear whether trailing whitespace is supposed to be significant or not(FidoNet specs don't say), but I don't see any reason why "John Doe" and"John Doe " should be considered unique senders or recipients. Remove anytrailing whitespace from message subjects too.This change makes the trailing whitespace truncation in SMB hash functionsunnecessary (at least for SBBSecho-imported messages), but most (all?) othermessage transports don't allow for this nonsense in the first place.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Mon Jun 26 11:03:45 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/e76fafaae4580941b343253b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix type 2.2 packet header generationAs reported by Deon on DOVE-Net: type 2.2 packet generation was not (sinceSBBSecho v3.0) setting the origin and destination point values correctly:was leaving the packet type 2.0 date values in these fields.Also, zero-out the reserved bytes in the type 2.2 packet header (don't leavethe type 2.0 date values in there).Thanks for the report Deon!
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Thu Jul 20 11:53:05 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/68df9812f31add3f94430d77
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Always delete the AREASxxxxxx temp fileWhen there are no changes (areas added or removed) via an areafix message, thedata/AREASxxxxxx temp file would be left behind. The file was only removed ifareas were added or removed from the area file via areafix message.The orphaned data/AREASxxxxxxx files were reported via DOVE-Net by Gamgee (PALANTIR)If you have these stale files, you can safely delete them.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Sun Sep 17 23:27:45 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/f9b0dda5a1cac371a50f9f3f
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Add more detail (e.g. line number) to various "error opening" log msgsSome of the errors could be pretty vague since they looked the same andwe were depending on the path/file attempted to be opened in the log msgto clue us into what exactly was being attempted. But some of these filepaths are sysop-configurable, and they can put unexpected things in therethat make it difficult to determine exactly what file was trying to beopened and for what purpose. This should help a little bit.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Fri Oct 20 20:19:52 2023
    src/sbbs3 sbbsecho.c 3.132 3.133
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv10170

    Modified Files:
    sbbsecho.c
    Log Message:
    When importing FTN TZUTC values, don't get fancy trying to convert to a US standard time-zone (e.g. -0300 == EST) as this is not accurate when daylight saving time is in effect (-0400 == EDT or AST?).


    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Alterego@1:103/705 to Digital Man on Fri Oct 20 20:19:52 2023
    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Sun Aug 18 2019 12:04 pm

    Fix possible NULL-dereference in pack_netmail(), likely the problem that Alterego reported, would cause a crash if the netmail message did *not* have a FLAGS kludge line.

    Ahh, you might have found it?

    I'll rebuild and try with the same message anyway...
    ...*

    ... Nursing Law: All the IV trees are at the other end of the hall.

    ---
    Synchronet Alterant | an SBBS in Docker on Pi!
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Digital Man@1:103/705 to Alterego on Fri Oct 20 20:19:52 2023
    Re: src/sbbs3/sbbsecho.c
    By: Alterego to Digital Man on Mon Aug 19 2019 08:21 am

    Re: src/sbbs3/sbbsecho.c
    By: rswindell to CVS commit on Sun Aug 18 2019 12:04 pm

    Fix possible NULL-dereference in pack_netmail(), likely the problem that Alterego reported, would cause a crash if the netmail message did *not* have a FLAGS kludge line.

    Ahh, you might have found it?

    I think so.

    I'll rebuild and try with the same message anyway...

    Thanks!

    digital man

    Synchronet "Real Fact" #37:
    Synchronet's Windows Control Panel is built with Borland C++ Builder.
    Norco, CA WX: 84.4F, 46.0% humidity, 15 mph NE wind, 0.00 inches rain/24hrs --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Fri Oct 20 20:19:52 2023
    src/sbbs3 sbbsecho.c 3.134 3.135
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv28445

    Modified Files:
    sbbsecho.c
    Log Message:
    Using the new lookup_user() function for destinatino user name look-ups.

    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Fri Oct 20 20:19:52 2023
    src/sbbs3 sbbsecho.c 3.138 3.139
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6532

    Modified Files:
    sbbsecho.c
    Log Message:
    Don't require that the last character of the "DateTime" field of packed messages is a null (0x00) byte. Some broken FidoNet software may include
    a full 20 usable characters in their DateTime header field, like so:
    "04 Feb 119 20:26:32" - representing February 4th, 2019. Y2K. <sigh>

    The DateTime won't be parsed fully correct, but at least the packet won't be rejected outright because it is "Grunged". - for Alterego (ALTERANT)


    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Mon Dec 4 21:14:35 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/43fb687f2e138e183f841a42
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix issue when packing netmails for multiple different linked-nodes

    Introduced in commit 15b230af (9 months ago), the first linked-node config (including packet password!) for the first packed netmail message would be reused for subsequent packed netmail messages.

    Thank you to Wilfred van Velzen (2:280/464) for reporting this problem!

    Additional debug-level log message when using a packet password for a newly created packet.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Mon Dec 4 22:57:40 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/28e435bdc2e909f38032afd4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Combine the "new packet" and "password-protected" debug-log lines

    ... to de-clutter the log

    Also, don't log the packet passwords. Folks copy and post sbbsecho.log lines and that could seriously compromise the security of the Interwebs if those super-secret passwords were ever leaked!
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Fri Dec 15 17:25:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/fc9d641054b36d9a84cc87da
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sun Dec 31 17:16:52 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/6e1118af6abf0c55ca608a29
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't use wildcard node packet password (if one exists)

    This also addresses the addresses with 65535 in them in the new debug-level
    log messages "New packet (type x) created for linked-node" .
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sun Dec 31 17:16:52 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/c2f663c30ab71c7493babab4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Log message attributes in human-readable form (not just hexadecimal)
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sun Jan 7 20:47:22 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/623613492036f9806c225436
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Expand sole-LFs in message text (shouldn't normally be there)

    Expanded to CRLF or just CR (if strip LFs is enabled).

    It is possible for someone to stuff LF-terminated text in a message, so let's account for that possibility upon export to FTNs where LFs are supposed to be ignored.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Wed Feb 7 10:47:17 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/20aecd3a4d979af82e3f509b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix more warnings...

    It looks like we may need a set of PRI?TIME macros for printf()ing
    a time_t.
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sat Mar 16 20:11:36 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9b28769f4b669763409f0435
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Bugfix: actually use the SMB netattr 'HOLD' attribute flag

    ... when exporting from SMB to .msg ("stored message") file
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sat Mar 23 16:12:16 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/4c7a908f8ee55161faf3be71
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Insure buf is null-terminated in getzpt(), resoving CID 488308
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Sat Mar 23 17:13:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/5a2a73ae1b20ddf3563c23fe
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit to this file
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)