• mbfile adopt with -virus option

    From Vince Coen@2:250/1 to All on Sun Dec 10 18:27:17 2017
    Hello All!

    Anyone use mbfile adopt area "description" -virus ?

    I cannot seem to get it to NOT do a virus check.

    Worse, I cannot see anything wrong in the code.

    [ code is in mbfido directory. ]


    Vince

    --- Mageia Linux v5.1/Mbse v1.0.7.4/GoldED+/LNX 1.1.501-b20150715
    * Origin: Air Applewood, The Linux Gateway to the UK & Eire (2:250/1)
  • From Andrew Leary@1:320/219 to Vince Coen on Sun Dec 10 16:56:01 2017
    Hello Vince!

    10 Dec 17 18:27, you wrote to all:

    Anyone use mbfile adopt area "description" -virus ?

    I cannot seem to get it to NOT do a virus check.

    Worse, I cannot see anything wrong in the code.

    [ code is in mbfido directory. ]

    It looks like the command line parsing code in mbfile.c is only checking for the -virus option when doing the import operation, not the adopt operation. I should be able to add it for the adopt operation fairly easily; I'll work on it tonight.

    Andrew

    --- GoldED+/LNX 1.1.5-b20170303
    * Origin: Phoenix BBS * phoenix.bnbbbs.net (1:320/219)
  • From Vince Coen@2:250/1 to Andrew Leary on Mon Dec 11 14:35:33 2017
    Hello Andrew!

    Sunday December 10 2017 16:56, you wrote to me:

    Hello Vince!

    10 Dec 17 18:27, you wrote to all:

    Anyone use mbfile adopt area "description" -virus ?

    I cannot seem to get it to NOT do a virus check.

    Worse, I cannot see anything wrong in the code.

    [ code is in mbfido directory. ]

    It looks like the command line parsing code in mbfile.c is only
    checking for the -virus option when doing the import operation, not
    the adopt operation. I should be able to add it for the adopt
    operation fairly easily; I'll work on it tonight.

    Yes, I did see the 'break' but was not sure if it exited the current if or the first if - sound like it is all of the if's.


    Teach me not to verify with a book :(


    Vince

    --- Mageia Linux v5.1/Mbse v1.0.7.4/GoldED+/LNX 1.1.501-b20150715
    * Origin: Air Applewood, The Linux Gateway to the UK & Eire (2:250/1)
  • From Vince Coen@2:250/1 to Andrew Leary on Tue Dec 12 19:25:40 2017
    Hello Andrew!

    Sunday December 10 2017 16:56, you wrote to me:

    Hello Vince!

    10 Dec 17 18:27, you wrote to all:

    Anyone use mbfile adopt area "description" -virus ?

    I cannot seem to get it to NOT do a virus check.

    Worse, I cannot see anything wrong in the code.

    [ code is in mbfido directory. ]

    It looks like the command line parsing code in mbfile.c is only
    checking for the -virus option when doing the import operation, not
    the adopt operation. I should be able to add it for the adopt
    operation fairly easily; I'll work on it tonight.

    As a follow on from the bug report #20 for this :

    I remarked out the line with break as :

    --
    cmd = xstrcat(cmd, argv[i]);
    if (argc > (i + 1)) {
    i++;
    cmd = xstrcat(cmd, (char *)" ");
    cmd = xstrcat(cmd, argv[i]);
    if (!strncasecmp(argv[i], "-a", 2)) {
    do_annon = TRUE;
    } else if (!strncasecmp(argv[i], "-v", 2)) {
    do_novir = TRUE;
    } else {
    Description = xstrcpy(argv[i]);
    }
    }
    /* break; */
    }
    --

    and it now works as v1.0.7.5.

    Can you give me the commands for hg to do (similar to svn etc) :

    1. diff against my code and repo.
    2. commit my changes.
    Not for now but

    3. Update my copy of the sources to current repo with any changes.

    I have updated :
    Changelog and
    version to 1.0.7.5

    I have also in my copy of this version also updated mbfido/filefind.c :

    --
    /*
    * The next constants are to prevent overflowing the echomail areas
    * with huge replies. MAX_DESC_LINES limits the number of file description
    * lines, 5 should be enough. The other two are the maximum files to report
    * if in the same area or different area.
    * For netmail replies there is a different limit.
    */
    #define MAX_DESC_LINES 10
    #define MAX_FILES_SAMEBOARD 100
    #define MAX_FILES_OTHERBOARD 200
    #define MAX_FILES_NETMAIL 500
    --

    Why? the limited are very small in a internet age in consideration of the very
    low volume of such requests these days.


    Thanks,


    Vince

    --- Mageia Linux v5.1/Mbse v1.0.7.4/GoldED+/LNX 1.1.501-b20150715
    * Origin: Air Applewood, The Linux Gateway to the UK & Eire (2:250/1)